HDFS-4633 |
TestDFSClientExcludedNodes fails sporadically if excluded nodes cache expires too quickly |
Major |
hdfs-client, test |
Chris Nauroth |
Chris Nauroth |
HADOOP-9635 |
Fix Potential Stack Overflow in DomainSocket.c |
Major |
native |
V. Karthik Kumar |
|
MAPREDUCE-5316 |
job -list-attempt-ids command does not handle illegal task-state |
Major |
client |
Ashwin Shankar |
Ashwin Shankar |
HADOOP-9582 |
Non-existent file to “hadoop fs -conf” doesn’t throw error |
Major |
conf |
Ashwin Shankar |
Ashwin Shankar |
HADOOP-9660 |
[WINDOWS] Powershell / cmd parses -Dkey=value from command line as [-Dkey, value] which breaks GenericsOptionParser |
Major |
scripts, util |
Enis Soztutar |
Enis Soztutar |
HADOOP-9703 |
org.apache.hadoop.ipc.Client leaks threads on stop. |
Minor |
. |
Mark Miller |
Tsuyoshi Ozawa |
HDFS-4657 |
Limit the number of blocks logged by the NN after a block report to a configurable value. |
Major |
namenode |
Aaron T. Myers |
Aaron T. Myers |
MAPREDUCE-5380 |
Invalid mapred command should return non-zero exit code |
Major |
. |
Stephen Chu |
Stephen Chu |
MAPREDUCE-5404 |
HSAdminServer does not use ephemeral ports in minicluster mode |
Major |
jobhistoryserver |
Ted Yu |
Ted Yu |
HADOOP-9787 |
ShutdownHelper util to shutdown threads and threadpools |
Major |
util |
Karthik Kambatla |
Karthik Kambatla |
HADOOP-9817 |
FileSystem#globStatus and FileContext#globStatus need to work with symlinks |
Major |
. |
Colin P. McCabe |
Colin P. McCabe |
HDFS-5065 |
TestSymlinkHdfsDisable fails on Windows |
Major |
hdfs-client, test |
Ivan Mitic |
Ivan Mitic |
HADOOP-9847 |
TestGlobPath symlink tests fail to cleanup properly |
Minor |
. |
Andrew Wang |
Colin P. McCabe |
YARN-1060 |
Two tests in TestFairScheduler are missing @Test annotation |
Major |
scheduler |
Sandy Ryza |
Niranjan Singh |
HADOOP-9871 |
Fix intermittent findbug warnings in DefaultMetricsSystem |
Minor |
. |
Luke Lu |
Junping Du |
HDFS-4816 |
transitionToActive blocks if the SBN is doing checkpoint image transfer |
Major |
namenode |
Andrew Wang |
Andrew Wang |
HADOOP-9875 |
TestDoAsEffectiveUser can fail on JDK 7 |
Minor |
test |
Aaron T. Myers |
Aaron T. Myers |
HDFS-5093 |
TestGlobPaths should re-use the MiniDFSCluster to avoid failure on Windows |
Minor |
test |
Chuan Liu |
Chuan Liu |
HADOOP-9865 |
FileContext.globStatus() has a regression with respect to relative path |
Major |
. |
Chuan Liu |
Chuan Liu |
HDFS-4994 |
Audit log getContentSummary() calls |
Minor |
namenode |
Kihwal Lee |
Robert Parker |
HADOOP-9887 |
globStatus does not correctly handle paths starting with a drive spec on Windows |
Major |
fs |
Chris Nauroth |
Chuan Liu |
HDFS-4329 |
DFSShell issues with directories with spaces in name |
Major |
hdfs-client |
Andy Isaacson |
Cristina L. Abad |
HDFS-3981 |
access time is set without holding FSNamesystem write lock |
Major |
namenode |
Xiaobo Peng |
Xiaobo Peng |
HADOOP-9889 |
Refresh the Krb5 configuration when creating a new kdc in Hadoop-MiniKDC |
Major |
. |
Wei Yan |
Wei Yan |
HADOOP-9908 |
Fix NPE when versioninfo properties file is missing |
Major |
util |
Todd Lipcon |
Todd Lipcon |
HDFS-5164 |
deleteSnapshot should check if OperationCategory.WRITE is possible before taking write lock |
Minor |
namenode |
Colin P. McCabe |
Colin P. McCabe |
HDFS-5170 |
BlockPlacementPolicyDefault uses the wrong classname when alerting to enable debug logging |
Trivial |
. |
Andrew Wang |
Andrew Wang |
HADOOP-9350 |
Hadoop not building against Java7 on OSX |
Minor |
build |
Steve Loughran |
Robert Kanter |
HDFS-5122 |
Support failover and retry in WebHdfsFileSystem for NN HA |
Major |
ha, webhdfs |
Arpit Gupta |
Haohui Mai |
HADOOP-9929 |
Insufficient permissions for a path reported as file not found |
Major |
fs |
Jason Lowe |
Colin P. McCabe |
HADOOP-9791 |
Add a test case covering long paths for new FileUtil access check methods |
Major |
. |
Ivan Mitic |
Ivan Mitic |
MAPREDUCE-5504 |
mapred queue -info inconsistent with types |
Major |
client |
Thomas Graves |
Kousuke Saruta |
HADOOP-7344 |
globStatus doesn’t grok groupings with a slash |
Major |
fs |
Daryn Sharp |
Colin P. McCabe |
YARN-1188 |
The context of QueueMetrics becomes ‘default’ when using FairScheduler |
Trivial |
. |
Akira Ajisaka |
Tsuyoshi Ozawa |
MAPREDUCE-5522 |
Incorrectly expect the array of JobQueueInfo returned by o.a.h.mapred.QueueManager#getJobQueueInfos to have a specific order. |
Minor |
test |
Jinghui Wang |
Jinghui Wang |
HADOOP-9981 |
globStatus should minimize its listStatus and getFileStatus calls |
Critical |
. |
Kihwal Lee |
Colin P. McCabe |
MAPREDUCE-5514 |
TestRMContainerAllocator fails on trunk |
Blocker |
. |
Zhijie Shen |
Zhijie Shen |
HADOOP-10006 |
Compilation failure in trunk for o.a.h.fs.swift.util.JSONUtil |
Blocker |
fs, util |
Junping Du |
Junping Du |
HADOOP-9964 |
O.A.H.U.ReflectionUtils.printThreadInfo() is not thread-safe which cause TestHttpServer pending 10 minutes or longer. |
Major |
util |
Junping Du |
Junping Du |
YARN-1268 |
TestFairScheduler.testContinuousScheduling is flaky |
Major |
scheduler |
Sandy Ryza |
Sandy Ryza |
HADOOP-10028 |
Malformed ssl-server.xml.example |
Minor |
. |
Jing Zhao |
Haohui Mai |
HDFS-5291 |
Clients need to retry when Active NN is in SafeMode |
Critical |
ha |
Arpit Gupta |
Jing Zhao |
HADOOP-10030 |
FsShell -put/copyFromLocal should support Windows local path |
Major |
. |
Chuan Liu |
Chuan Liu |
YARN-1284 |
LCE: Race condition leaves dangling cgroups entries for killed containers |
Blocker |
nodemanager |
Alejandro Abdelnur |
Alejandro Abdelnur |
YARN-461 |
Fair scheduler should not accept apps with empty string queue name |
Major |
resourcemanager |
Sandy Ryza |
Wei Yan |
MAPREDUCE-5569 |
FloatSplitter is not generating correct splits |
Major |
. |
Nathan Roberts |
Nathan Roberts |
YARN-879 |
Fix tests w.r.t o.a.h.y.server.resourcemanager.Application |
Major |
. |
Junping Du |
Junping Du |
HADOOP-10031 |
FsShell -get/copyToLocal/moveFromLocal should support Windows local path |
Major |
fs |
Chuan Liu |
Chuan Liu |
YARN-1265 |
Fair Scheduler chokes on unhealthy node reconnect |
Major |
resourcemanager, scheduler |
Sandy Ryza |
Sandy Ryza |
HADOOP-10029 |
Specifying har file to MR job fails in secure cluster |
Major |
fs |
Suresh Srinivas |
Suresh Srinivas |
HDFS-5335 |
DFSOutputStream#close() keeps throwing exceptions when it is called multiple times |
Major |
. |
Arpit Gupta |
Haohui Mai |
HADOOP-10039 |
Add Hive to the list of projects using AbstractDelegationTokenSecretManager |
Major |
security |
Suresh Srinivas |
Haohui Mai |
YARN-1300 |
SLS tests fail because conf puts yarn properties in fair-scheduler.xml |
Major |
. |
Ted Yu |
Ted Yu |
HDFS-5322 |
HDFS delegation token not found in cache errors seen on secure HA clusters |
Major |
ha |
Arpit Gupta |
Jing Zhao |
YARN-1044 |
used/min/max resources do not display info in the scheduler page |
Critical |
resourcemanager, scheduler |
Sangjin Lee |
Sangjin Lee |
HDFS-5329 |
Update FSNamesystem#getListing() to handle inode path in startAfter token |
Major |
namenode, nfs |
Brandon Li |
Brandon Li |
MAPREDUCE-5329 |
APPLICATION_INIT is never sent to AuxServices other than the builtin ShuffleHandler |
Major |
mr-am |
Avner BenHanoch |
Avner BenHanoch |
YARN-305 |
Fair scheduler logs too many “Node offered to app:…” messages |
Critical |
resourcemanager |
Lohit Vijayarenu |
Lohit Vijayarenu |
HADOOP-10040 |
hadoop.cmd in UNIX format and would not run by default on Windows |
Major |
. |
Yingda Chen |
Chris Nauroth |
MAPREDUCE-5546 |
mapred.cmd on Windows set HADOOP_OPTS incorrectly |
Major |
. |
Chuan Liu |
Chuan Liu |
YARN-1259 |
In Fair Scheduler web UI, queue num pending and num active apps switched |
Trivial |
scheduler |
Sandy Ryza |
Robert Kanter |
YARN-1182 |
MiniYARNCluster creates and inits the RM/NM only on start() |
Major |
. |
Karthik Kambatla |
Karthik Kambatla |
HDFS-5352 |
Server#initLog() doesn’t close InputStream in httpfs |
Minor |
. |
Ted Yu |
Ted Yu |
MAPREDUCE-5518 |
Fix typo “can’t read paritions file” |
Trivial |
examples |
Albert Chu |
Albert Chu |
YARN-1295 |
In UnixLocalWrapperScriptBuilder, using bash -c can cause “Text file busy” errors |
Major |
nodemanager |
Sandy Ryza |
Sandy Ryza |
HDFS-5283 |
NN not coming out of startup safemode due to under construction blocks only inside snapshots also counted in safemode threshhold |
Critical |
snapshots |
Vinayakumar B |
Vinayakumar B |
MAPREDUCE-5585 |
TestCopyCommitter#testNoCommitAction Fails on JDK7 |
Major |
. |
Jonathan Eagles |
Jonathan Eagles |
MAPREDUCE-5586 |
TestCopyMapper#testCopyFailOnBlockSizeDifference fails when run from hadoop-tools/hadoop-distcp directory |
Major |
. |
Jonathan Eagles |
Jonathan Eagles |
HDFS-5370 |
Typo in Error Message: different between range in condition and range in error message |
Trivial |
hdfs-client |
Kousuke Saruta |
Kousuke Saruta |
HDFS-5346 |
Avoid unnecessary call to getNumLiveDataNodes() for each block during IBR processing |
Major |
namenode, performance |
Kihwal Lee |
Ravi Prakash |
HDFS-4376 |
Fix several race conditions in Balancer and resolve intermittent timeout of TestBalancerWithNodeGroup |
Major |
balancer & mover |
Aaron T. Myers |
Junping Du |
HDFS-5375 |
hdfs.cmd does not expose several snapshot commands. |
Minor |
tools |
Chris Nauroth |
Chris Nauroth |
HDFS-5336 |
DataNode should not output ‘StartupProgress’ metrics |
Minor |
namenode |
Akira Ajisaka |
Akira Ajisaka |
HADOOP-10055 |
FileSystemShell.apt.vm doc has typo “numRepicas” |
Trivial |
documentation |
Eli Collins |
Akira Ajisaka |
HDFS-5374 |
Remove deadcode in DFSOutputStream |
Trivial |
. |
Suresh Srinivas |
Suresh Srinivas |
HDFS-5365 |
Fix libhdfs compile error on FreeBSD9 |
Major |
build, libhdfs |
Radim Kolar |
Radim Kolar |
MAPREDUCE-5587 |
TestTextOutputFormat fails on JDK7 |
Major |
. |
Jonathan Eagles |
Jonathan Eagles |
HDFS-5276 |
FileSystem.Statistics got performance issue on multi-thread read/write. |
Major |
. |
Chengxiang Li |
Colin P. McCabe |
YARN-1288 |
Make Fair Scheduler ACLs more user friendly |
Major |
scheduler |
Sandy Ryza |
Sandy Ryza |
YARN-1331 |
yarn.cmd exits with NoClassDefFoundError trying to run rmadmin or logs |
Trivial |
client |
Chris Nauroth |
Chris Nauroth |
YARN-1315 |
TestQueueACLs should also test FairScheduler |
Major |
resourcemanager, scheduler |
Sandy Ryza |
Sandy Ryza |
HDFS-5400 |
DFS_CLIENT_MMAP_CACHE_THREAD_RUNS_PER_TIMEOUT constant is set to the wrong value |
Major |
. |
Colin P. McCabe |
Colin P. McCabe |
MAPREDUCE-5561 |
org.apache.hadoop.mapreduce.v2.app.job.impl.TestJobImpl testcase failing on trunk |
Critical |
. |
Cindy Li |
Karthik Kambatla |
YARN-1183 |
MiniYARNCluster shutdown takes several minutes intermittently |
Major |
. |
Andrey Klochkov |
Andrey Klochkov |
HDFS-5403 |
WebHdfs client cannot communicate with older WebHdfs servers post HDFS-5306 |
Major |
webhdfs |
Aaron T. Myers |
Aaron T. Myers |
HADOOP-9016 |
org.apache.hadoop.fs.HarFileSystem.HarFSDataInputStream.HarFsInputStream.skip(long) must never return negative value. |
Minor |
. |
Ivan A. Veselovsky |
Ivan A. Veselovsky |
HDFS-5341 |
Reduce fsdataset lock duration during directory scanning. |
Major |
datanode |
qus-jiawei |
qus-jiawei |
HDFS-5257 |
addBlock() retry should return LocatedBlock with locations else client will get AIOBE |
Major |
hdfs-client, namenode |
Vinayakumar B |
Vinayakumar B |
HADOOP-10072 |
TestNfsExports#testMultiMatchers fails due to non-deterministic timing around cache expiry check. |
Trivial |
nfs, test |
Chris Nauroth |
Chris Nauroth |
YARN-1022 |
Unnecessary INFO logs in AMRMClientAsync |
Trivial |
. |
Bikas Saha |
haosdent |
YARN-1349 |
yarn.cmd does not support passthrough to any arbitrary class. |
Major |
client |
Chris Nauroth |
Chris Nauroth |
HDFS-5413 |
hdfs.cmd does not support passthrough to any arbitrary class. |
Major |
scripts |
Chris Nauroth |
Chris Nauroth |
MAPREDUCE-4680 |
Job history cleaner should only check timestamps of files in old enough directories |
Major |
jobhistoryserver |
Sandy Ryza |
Robert Kanter |
MAPREDUCE-5598 |
TestUserDefinedCounters.testMapReduceJob is flakey |
Major |
test |
Robert Kanter |
Robert Kanter |
YARN-1306 |
Clean up hadoop-sls sample-conf according to YARN-1228 |
Major |
. |
Wei Yan |
Wei Yan |
HDFS-5433 |
When reloading fsimage during checkpointing, we should clear existing snapshottable directories |
Critical |
snapshots |
Aaron T. Myers |
Aaron T. Myers |
HDFS-5432 |
TestDatanodeJsp fails on Windows due to assumption that loopback address resolves to host name localhost. |
Trivial |
datanode, test |
Chris Nauroth |
Chris Nauroth |
YARN-1321 |
NMTokenCache is a singleton, prevents multiple AMs running in a single JVM to work correctly |
Blocker |
client |
Alejandro Abdelnur |
Alejandro Abdelnur |
YARN-1343 |
NodeManagers additions/restarts are not reported as node updates in AllocateResponse responses to AMs |
Critical |
resourcemanager |
Alejandro Abdelnur |
Alejandro Abdelnur |
YARN-1381 |
Same relaxLocality appears twice in exception message of AMRMClientImpl#checkLocalityRelaxationConflict() |
Minor |
. |
Ted Yu |
Ted Yu |
HADOOP-9898 |
Set SO_KEEPALIVE on all our sockets |
Minor |
ipc, net |
Todd Lipcon |
Todd Lipcon |
MAPREDUCE-5604 |
TestMRAMWithNonNormalizedCapabilities fails on Windows due to exceeding max path length |
Minor |
test |
Chris Nauroth |
Chris Nauroth |
HDFS-5035 |
getFileLinkStatus and rename do not correctly check permissions of symlinks |
Major |
namenode |
Andrew Wang |
Andrew Wang |
YARN-1388 |
Fair Scheduler page always displays blank fair share |
Trivial |
resourcemanager |
Liyin Liang |
Liyin Liang |
HDFS-5456 |
NameNode startup progress creates new steps if caller attempts to create a counter for a step that doesn’t already exist. |
Critical |
namenode |
Chris Nauroth |
Chris Nauroth |
HDFS-5427 |
not able to read deleted files from snapshot directly under snapshottable dir after checkpoint and NN restart |
Major |
snapshots |
Vinayakumar B |
Vinayakumar B |
YARN-1374 |
Resource Manager fails to start due to ConcurrentModificationException |
Blocker |
resourcemanager |
Devaraj K |
Karthik Kambatla |
HDFS-5458 |
Datanode failed volume threshold ignored if exception is thrown in getDataDirsFromURIs |
Major |
datanode |
Andrew Wang |
Mike Mellenthin |
MAPREDUCE-5451 |
MR uses LD_LIBRARY_PATH which doesn’t mean anything in Windows |
Major |
. |
Mostafa Elhemali |
Yingda Chen |
HDFS-5443 |
Delete 0-sized block when deleting an under-construction file that is included in snapshot |
Major |
snapshots |
Uma Maheswara Rao G |
Jing Zhao |
HDFS-5468 |
CacheAdmin help command does not recognize commands |
Minor |
tools |
Stephen Chu |
Stephen Chu |
HDFS-5476 |
Snapshot: clean the blocks/files/directories under a renamed file/directory while deletion |
Major |
. |
Jing Zhao |
Jing Zhao |
HDFS-5482 |
DistributedFileSystem#listPathBasedCacheDirectives must support relative paths |
Major |
tools |
Stephen Chu |
Colin P. McCabe |
HADOOP-10088 |
copy-nativedistlibs.sh needs to quote snappy lib dir |
Major |
build |
Raja Aluri |
Raja Aluri |
MAPREDUCE-5186 |
mapreduce.job.max.split.locations causes some splits created by CombineFileInputFormat to fail |
Critical |
job submission |
Sangjin Lee |
Robert Parker |
YARN-1395 |
Distributed shell application master launched with debug flag can hang waiting for external ls process. |
Major |
applications/distributed-shell |
Chris Nauroth |
Chris Nauroth |
YARN-1400 |
yarn.cmd uses HADOOP_RESOURCEMANAGER_OPTS. Should be YARN_RESOURCEMANAGER_OPTS. |
Trivial |
resourcemanager |
Raja Aluri |
Raja Aluri |
HDFS-5425 |
Renaming underconstruction file with snapshots can make NN failure on restart |
Major |
namenode, snapshots |
sathish |
Jing Zhao |
HDFS-5471 |
CacheAdmin -listPools fails when user lacks permissions to view all pools |
Major |
tools |
Stephen Chu |
Andrew Wang |
HADOOP-10093 |
hadoop-env.cmd sets HADOOP_CLIENT_OPTS with a max heap size that is too small. |
Major |
conf |
shanyu zhao |
shanyu zhao |
YARN-1386 |
NodeManager mistakenly loses resources and relocalizes them |
Critical |
nodemanager |
Jason Lowe |
Jason Lowe |
MAPREDUCE-5613 |
DefaultSpeculator holds and checks hashmap that is always empty |
Major |
applicationmaster |
Gera Shegalov |
Gera Shegalov |
MAPREDUCE-5431 |
Missing pom dependency in MR-client |
Major |
build |
Timothy St. Clair |
Timothy St. Clair |
HDFS-5075 |
httpfs-config.sh calls out incorrect env script name |
Major |
. |
Timothy St. Clair |
Timothy St. Clair |
HDFS-5474 |
Deletesnapshot can make Namenode in safemode on NN restarts. |
Major |
snapshots |
Uma Maheswara Rao G |
sathish |
HADOOP-10078 |
KerberosAuthenticator always does SPNEGO |
Minor |
security |
Robert Kanter |
Robert Kanter |
HDFS-5504 |
In HA mode, OP_DELETE_SNAPSHOT is not decrementing the safemode threshold, leads to NN safemode. |
Major |
snapshots |
Vinayakumar B |
Vinayakumar B |
MAPREDUCE-5481 |
Enable uber jobs to have multiple reducers |
Blocker |
mrv2, test |
Jason Lowe |
Sandy Ryza |
HDFS-4995 |
Make getContentSummary() less expensive |
Major |
namenode |
Kihwal Lee |
Kihwal Lee |
HADOOP-10094 |
NPE in GenericOptionsParser#preProcessForWindows() |
Trivial |
util |
Enis Soztutar |
Enis Soztutar |
MAPREDUCE-5616 |
MR Client-AppMaster RPC max retries on socket timeout is too high. |
Major |
client |
Chris Nauroth |
Chris Nauroth |
YARN-1401 |
With zero sleep-delay-before-sigkill.ms, no signal is ever sent |
Major |
nodemanager |
Gera Shegalov |
Gera Shegalov |
HDFS-5438 |
Flaws in block report processing can cause data loss |
Critical |
namenode |
Kihwal Lee |
Kihwal Lee |
HADOOP-10100 |
MiniKDC shouldn’t use apacheds-all artifact |
Major |
. |
Robert Kanter |
Robert Kanter |
MAPREDUCE-5373 |
TestFetchFailure.testFetchFailureMultipleReduces could fail intermittently |
Major |
. |
Chuan Liu |
Jonathan Eagles |
HDFS-5372 |
In FSNamesystem, hasReadLock() returns false if the current thread holds the write lock |
Major |
namenode |
Tsz Wo Nicholas Sze |
Vinayakumar B |
YARN-1419 |
TestFifoScheduler.testAppAttemptMetrics fails intermittently under jdk7 |
Minor |
scheduler |
Jonathan Eagles |
Jonathan Eagles |
HDFS-5512 |
CacheAdmin -listPools fails with NPE when user lacks permissions to view all pools |
Major |
caching, tools |
Stephen Chu |
Andrew Wang |
HDFS-5073 |
TestListCorruptFileBlocks fails intermittently |
Minor |
test |
Kihwal Lee |
Arpit Agarwal |
HDFS-5428 |
under construction files deletion after snapshot+checkpoint+nn restart leads nn safemode |
Major |
snapshots |
Vinayakumar B |
Jing Zhao |
YARN-584 |
In scheduler web UIs, queues unexpand on refresh |
Major |
scheduler |
Sandy Ryza |
Harshit Daga |
HDFS-5513 |
CacheAdmin commands fail when using . as the path |
Minor |
caching, tools |
Stephen Chu |
Andrew Wang |
YARN-1407 |
RM Web UI and REST APIs should uniformly use YarnApplicationState |
Major |
. |
Sandy Ryza |
Sandy Ryza |
HDFS-4516 |
Client crash after block allocation and NN switch before lease recovery for the same file can cause readers to fail forever |
Critical |
namenode |
Uma Maheswara Rao G |
Vinayakumar B |
HDFS-5014 |
BPOfferService#processCommandFromActor() synchronization on namenode RPC call delays IBR to Active NN, if Stanby NN is unstable |
Major |
datanode, ha |
Vinayakumar B |
Vinayakumar B |
YARN-1425 |
TestRMRestart fails because MockRM.waitForState(AttemptId) uses current attempt instead of the attempt passed as argument |
Major |
. |
Omkar Vinit Joshi |
Omkar Vinit Joshi |
YARN-1053 |
Diagnostic message from ContainerExitEvent is ignored in ContainerImpl |
Blocker |
. |
Omkar Vinit Joshi |
Omkar Vinit Joshi |
HADOOP-9114 |
After defined the dfs.checksum.type as the NULL, write file and hflush will through java.lang.ArrayIndexOutOfBoundsException |
Minor |
. |
liuyang |
sathish |
MAPREDUCE-5631 |
TestJobEndNotifier.testNotifyRetries fails with Should have taken more than 5 seconds in jdk7 |
Major |
. |
Jonathan Eagles |
Jonathan Eagles |
YARN-1320 |
Custom log4j properties in Distributed shell does not work properly. |
Major |
applications/distributed-shell |
Tassapol Athiapinya |
Xuan Gong |
HDFS-5407 |
Fix typos in DFSClientCache |
Trivial |
. |
Haohui Mai |
Haohui Mai |
HDFS-5544 |
Adding Test case For Checking dfs.checksum type as NULL value |
Minor |
hdfs-client |
sathish |
sathish |
HDFS-5552 |
Fix wrong information of “Cluster summay” in dfshealth.html |
Major |
namenode |
Shinichi Yamashita |
Haohui Mai |
HDFS-5533 |
Symlink delete/create should be treated as DELETE/CREATE in snapshot diff report |
Minor |
snapshots |
Binglin Chang |
Binglin Chang |
HADOOP-10126 |
LightWeightGSet log message is confusing : “2.0% max memory = 2.0 GB” |
Minor |
util |
Vinayakumar B |
Vinayakumar B |
YARN-1416 |
InvalidStateTransitions getting reported in multiple test cases even though they pass |
Major |
. |
Omkar Vinit Joshi |
Jian He |
YARN-1314 |
Cannot pass more than 1 argument to shell command |
Major |
applications/distributed-shell |
Tassapol Athiapinya |
Xuan Gong |
HDFS-5562 |
TestCacheDirectives and TestFsDatasetCache should stub out native mlock |
Major |
test |
Akira Ajisaka |
Colin P. McCabe |
YARN-1241 |
In Fair Scheduler, maxRunningApps does not work for non-leaf queues |
Major |
. |
Sandy Ryza |
Sandy Ryza |
HADOOP-10135 |
writes to swift fs over partition size leave temp files and empty output file |
Major |
fs |
David Dobbins |
David Dobbins |
HDFS-5581 |
NameNodeFsck should use only one instance of BlockPlacementPolicy |
Major |
namenode |
Vinayakumar B |
Vinayakumar B |
HADOOP-10130 |
RawLocalFS::LocalFSFileInputStream.pread does not track FS::Statistics |
Minor |
. |
Binglin Chang |
Binglin Chang |
HDFS-5557 |
Write pipeline recovery for the last packet in the block may cause rejection of valid replicas |
Critical |
. |
Kihwal Lee |
Kihwal Lee |
HDFS-5526 |
Datanode cannot roll back to previous layout version |
Blocker |
datanode |
Tsz Wo Nicholas Sze |
Kihwal Lee |
HDFS-5560 |
Trash configuration log statements prints incorrect units |
Major |
. |
Josh Elser |
Josh Elser |
HDFS-5558 |
LeaseManager monitor thread can crash if the last block is complete but another block is not. |
Major |
. |
Kihwal Lee |
Kihwal Lee |
HADOOP-10127 |
Add ipc.client.connect.retry.interval to control the frequency of connection retries |
Major |
ipc |
Karthik Kambatla |
Karthik Kambatla |
MAPREDUCE-5645 |
TestFixedLengthInputFormat fails with native libs |
Major |
. |
Jonathan Eagles |
Mit Desai |
YARN-1454 |
TestRMRestart.testRMDelegationTokenRestoredOnRMRestart is failing intermittently |
Critical |
. |
Jian He |
Karthik Kambatla |
HDFS-5555 |
CacheAdmin commands fail when first listed NameNode is in Standby |
Major |
caching |
Stephen Chu |
Jimmy Xiang |
HADOOP-10129 |
Distcp may succeed when it fails |
Critical |
tools/distcp |
Daryn Sharp |
Daryn Sharp |
HADOOP-10081 |
Client.setupIOStreams can leak socket resources on exception or error |
Critical |
ipc |
Jason Lowe |
Tsuyoshi Ozawa |
HADOOP-10058 |
TestMetricsSystemImpl#testInitFirstVerifyStopInvokedImmediately fails on trunk |
Minor |
metrics |
Akira Ajisaka |
Chen He |
YARN-1438 |
When a container fails, the text of the exception isn’t included in the diagnostics |
Major |
nodemanager |
Steve Loughran |
Steve Loughran |
YARN-546 |
Allow disabling the Fair Scheduler event log |
Major |
scheduler |
Lohit Vijayarenu |
Sandy Ryza |
HDFS-5590 |
Block ID and generation stamp may be reused when persistBlocks is set to false |
Major |
. |
Jing Zhao |
Jing Zhao |
YARN-1450 |
TestUnmanagedAMLauncher#testDSShell fails on trunk |
Major |
applications/distributed-shell |
Akira Ajisaka |
Binglin Chang |
HADOOP-10142 |
Avoid groups lookup for unprivileged users such as “dr.who” |
Major |
. |
Vinayakumar B |
Vinayakumar B |
HDFS-5353 |
Short circuit reads fail when dfs.encrypt.data.transfer is enabled |
Blocker |
. |
Haohui Mai |
Colin P. McCabe |
MAPREDUCE-5656 |
bzip2 codec can drop records when reading data in splits |
Critical |
. |
Jason Lowe |
Jason Lowe |
MAPREDUCE-5052 |
Job History UI and web services confusing job start time and job submit time |
Critical |
jobhistoryserver, webapps |
Kendall Thrapp |
Chen He |
HDFS-5074 |
Allow starting up from an fsimage checkpoint in the middle of a segment |
Major |
ha, namenode |
Todd Lipcon |
Todd Lipcon |
HDFS-5580 |
Infinite loop in Balancer.waitForMoveCompletion |
Major |
. |
Binglin Chang |
Binglin Chang |
YARN-1491 |
Upgrade JUnit3 TestCase to JUnit 4 |
Trivial |
. |
Jonathan Eagles |
Chen He |
HADOOP-10087 |
UserGroupInformation.getGroupNames() fails to return primary group first when JniBasedUnixGroupsMappingWithFallback is used |
Major |
security |
Yu Gao |
Colin P. McCabe |
YARN-408 |
Capacity Scheduler delay scheduling should not be disabled by default |
Minor |
scheduler |
Mayank Bansal |
Mayank Bansal |
HDFS-5023 |
TestSnapshotPathINodes.testAllowSnapshot is failing with jdk7 |
Major |
snapshots, test |
Ravi Prakash |
Mit Desai |
HDFS-4201 |
NPE in BPServiceActor#sendHeartBeat |
Critical |
namenode |
Eli Collins |
Jimmy Xiang |
MAPREDUCE-5674 |
Missing start and finish time in mapred.JobStatus |
Major |
client |
Chuan Liu |
Chuan Liu |
HADOOP-10162 |
Fix symlink-related test failures in TestFileContextResolveAfs and TestStat in branch-2 |
Major |
. |
Mit Desai |
Mit Desai |
HADOOP-8753 |
LocalDirAllocator throws “ArithmeticException: / by zero” when there is no available space on configured local dir |
Minor |
. |
Nishan Shetty |
Benoy Antony |
YARN-1435 |
Distributed Shell should not run other commands except “sh”, and run the custom script at the same time. |
Major |
applications/distributed-shell |
Tassapol Athiapinya |
Xuan Gong |
HDFS-5592 |
“DIR* completeFile: /file is closed by DFSClient_” should be logged only for successful closure of the file. |
Major |
. |
Vinayakumar B |
Vinayakumar B |
MAPREDUCE-5623 |
TestJobCleanup fails because of RejectedExecutionException and NPE. |
Major |
. |
Tsuyoshi Ozawa |
Jason Lowe |
HDFS-5666 |
Fix inconsistent synchronization in BPOfferService |
Minor |
namenode |
Colin P. McCabe |
Jimmy Xiang |
YARN-1505 |
WebAppProxyServer should not set localhost as YarnConfiguration.PROXY_ADDRESS by itself |
Blocker |
. |
Xuan Gong |
Xuan Gong |
YARN-1145 |
Potential file handle leak in aggregated logs web ui |
Major |
. |
Rohith Sharma K S |
Rohith Sharma K S |
HADOOP-10106 |
Incorrect thread name in RPC log messages |
Minor |
. |
Ming Ma |
Ming Ma |
MAPREDUCE-5679 |
TestJobHistoryParsing has race condition |
Major |
. |
Liyin Liang |
Liyin Liang |
HADOOP-10168 |
fix javadoc of ReflectionUtils.copy |
Major |
. |
Thejas M Nair |
Thejas M Nair |
YARN-1451 |
TestResourceManager relies on the scheduler assigning multiple containers in a single node update |
Minor |
. |
Sandy Ryza |
Sandy Ryza |
HDFS-5657 |
race condition causes writeback state error in NFS gateway |
Major |
nfs |
Brandon Li |
Brandon Li |
HDFS-5305 |
Add https support in HDFS |
Major |
. |
Suresh Srinivas |
Suresh Srinivas |
HADOOP-10171 |
TestRPC fails intermittently on jkd7 |
Major |
. |
Mit Desai |
Mit Desai |
HDFS-5661 |
Browsing FileSystem via web ui, should use datanode’s fqdn instead of ip address |
Major |
security |
Benoy Antony |
Benoy Antony |
HDFS-5540 |
Fix intermittent failure in TestBlocksWithNotEnoughRacks |
Minor |
. |
Binglin Chang |
Binglin Chang |
HDFS-5681 |
renewLease should not hold fsn write lock |
Major |
namenode |
Daryn Sharp |
Daryn Sharp |
YARN-1180 |
Update capacity scheduler docs to include types on the configs |
Trivial |
capacityscheduler |
Thomas Graves |
Chen He |
HDFS-5691 |
Fix typo in ShortCircuitLocalRead document |
Minor |
documentation |
Akira Ajisaka |
Akira Ajisaka |
MAPREDUCE-5550 |
Task Status message (reporter.setStatus) not shown in UI with Hadoop 2.0 |
Major |
. |
Vrushali C |
Gera Shegalov |
HDFS-5690 |
DataNode fails to start in secure mode when dfs.http.policy equals to HTTP_ONLY |
Blocker |
. |
Haohui Mai |
Haohui Mai |
HADOOP-10175 |
Har files system authority should preserve userinfo |
Major |
fs |
Chuan Liu |
Chuan Liu |
HADOOP-10090 |
Jobtracker metrics not updated properly after execution of a mapreduce job |
Major |
metrics |
Ivan Mitic |
Ivan Mitic |
YARN-1527 |
yarn rmadmin command prints wrong usage info: |
Trivial |
. |
Jian He |
Akira Ajisaka |
YARN-1541 |
Invalidate AM Host/Port when app attempt is done so that in the mean-while client doesn’t get wrong information. |
Major |
. |
Jian He |
Jian He |
MAPREDUCE-5694 |
MR AM container syslog is empty |
Major |
. |
Mohammad Kamrul Islam |
Mohammad Kamrul Islam |
HDFS-5675 |
Add Mkdirs operation to NNThroughputBenchmark |
Minor |
benchmarks |
Plamen Jeliazkov |
Plamen Jeliazkov |
HDFS-5582 |
hdfs getconf -excludeFile or -includeFile always failed |
Minor |
. |
Henry Hung |
sathish |
HDFS-5701 |
Fix the CacheAdmin -addPool -maxTtl option name |
Minor |
caching, tools |
Stephen Chu |
Stephen Chu |
MAPREDUCE-5685 |
getCacheFiles() api doesn’t work in WrappedReducer.java due to typo |
Blocker |
client |
Yi Song |
Yi Song |
YARN-1522 |
TestApplicationCleanup.testAppCleanup occasionally fails |
Major |
. |
Liyin Liang |
Liyin Liang |
HDFS-5671 |
Fix socket leak in DFSInputStream#getBlockReader |
Critical |
hdfs-client |
JamesLi |
JamesLi |
HADOOP-10147 |
Upgrade to commons-logging 1.1.3 to avoid potential deadlock in MiniDFSCluster |
Minor |
build |
Eric Sirianni |
Steve Loughran |
HDFS-5659 |
dfsadmin -report doesn’t output cache information properly |
Major |
caching |
Akira Ajisaka |
Andrew Wang |
MAPREDUCE-5689 |
MRAppMaster does not preempt reducers when scheduled maps cannot be fulfilled |
Critical |
. |
Lohit Vijayarenu |
Lohit Vijayarenu |
HADOOP-10193 |
hadoop-auth’s PseudoAuthenticationHandler can consume getInputStream |
Minor |
security |
Gregory Chanan |
Gregory Chanan |
HDFS-5719 |
FSImage#doRollback() should close prevState before return |
Minor |
namenode |
Ted Yu |
Ted Yu |
YARN-1409 |
NonAggregatingLogHandler can throw RejectedExecutionException |
Major |
. |
Tsuyoshi Ozawa |
Tsuyoshi Ozawa |
HDFS-5649 |
Unregister NFS and Mount service when NFS gateway is shutting down |
Major |
nfs |
Brandon Li |
Brandon Li |
YARN-1293 |
TestContainerLaunch.testInvalidEnvSyntaxDiagnostics fails on trunk |
Major |
. |
Tsuyoshi Ozawa |
Tsuyoshi Ozawa |
HADOOP-10214 |
Fix multithreaded correctness warnings in ActiveStandbyElector |
Major |
ha |
Liang Xie |
Liang Xie |
HDFS-5449 |
WebHdfs compatibility broken between 2.2 and 1.x / 23.x |
Blocker |
. |
Kihwal Lee |
Kihwal Lee |
YARN-1138 |
yarn.application.classpath is set to point to $HADOOP_CONF_DIR etc., which does not work on Windows |
Major |
api |
Yingda Chen |
Chuan Liu |
HADOOP-9420 |
Add percentile or max metric for rpcQueueTime, processing time |
Major |
ipc, metrics |
Todd Lipcon |
Liang Xie |
HDFS-5756 |
hadoopRzOptionsSetByteBufferPool does not accept NULL argument, contrary to docs |
Major |
libhdfs |
Colin P. McCabe |
Colin P. McCabe |
HADOOP-10178 |
Configuration deprecation always emit “deprecated” warnings when a new key is used |
Major |
conf |
shanyu zhao |
shanyu zhao |
HDFS-5747 |
BlocksMap.getStoredBlock(..) and BlockInfoUnderConstruction.addReplicaIfNotPresent(..) may throw NullPointerException |
Minor |
namenode |
Tsz Wo Nicholas Sze |
Arpit Agarwal |
HADOOP-10223 |
MiniKdc#main() should close the FileReader it creates |
Minor |
. |
Ted Yu |
Ted Yu |
YARN-888 |
clean up POM dependencies |
Major |
. |
Alejandro Abdelnur |
Alejandro Abdelnur |
HDFS-5710 |
FSDirectory#getFullPathName should check inodes against null |
Major |
. |
Ted Yu |
Uma Maheswara Rao G |
HDFS-5579 |
Under construction files make DataNode decommission take very long hours |
Major |
namenode |
yunjiong zhao |
yunjiong zhao |
HADOOP-10234 |
“hadoop.cmd jar” does not propagate exit code. |
Major |
scripts |
Chris Nauroth |
Chris Nauroth |
YARN-1603 |
Remove two *.orig files which were unexpectedly committed |
Trivial |
. |
Zhijie Shen |
Zhijie Shen |
YARN-1601 |
3rd party JARs are missing from hadoop-dist output |
Major |
. |
Alejandro Abdelnur |
Alejandro Abdelnur |
HADOOP-10236 |
Fix typo in o.a.h.ipc.Client#checkResponse |
Trivial |
. |
Akira Ajisaka |
Akira Ajisaka |
HDFS-5762 |
BlockReaderLocal doesn’t return -1 on EOF when doing zero-length reads |
Major |
. |
Colin P. McCabe |
Colin P. McCabe |
HDFS-5766 |
In DFSInputStream, do not add datanode to deadNodes after InvalidEncryptionKeyException in fetchBlockByteRange |
Major |
hdfs-client |
Liang Xie |
Liang Xie |
HDFS-5704 |
Change OP_UPDATE_BLOCKS with a new OP_ADD_BLOCK |
Major |
namenode |
Suresh Srinivas |
Jing Zhao |
HADOOP-10125 |
no need to process RPC request if the client connection has been dropped |
Major |
ipc |
Ming Ma |
Ming Ma |
YARN-1351 |
Invalid string format in Fair Scheduler log warn message |
Trivial |
resourcemanager |
Konstantin Weitz |
Konstantin Weitz |
HDFS-5777 |
Update LayoutVersion for the new editlog op OP_ADD_BLOCK |
Major |
namenode |
Jing Zhao |
Jing Zhao |
MAPREDUCE-5724 |
JobHistoryServer does not start if HDFS is not running |
Critical |
jobhistoryserver |
Alejandro Abdelnur |
Alejandro Abdelnur |
YARN-1608 |
LinuxContainerExecutor has a few DEBUG messages at INFO level |
Trivial |
nodemanager |
Karthik Kambatla |
Karthik Kambatla |
HADOOP-10146 |
Workaround JDK7 Process fd close bug |
Critical |
util |
Daryn Sharp |
Daryn Sharp |
MAPREDUCE-5650 |
Job fails when hprof mapreduce.task.profile.map/reduce.params is specified |
Major |
mrv2 |
Gera Shegalov |
Gera Shegalov |
HADOOP-10235 |
Hadoop tarball has 2 versions of stax-api JARs |
Major |
build |
Alejandro Abdelnur |
Alejandro Abdelnur |
HADOOP-10240 |
Windows build instructions incorrectly state requirement of protoc 2.4.1 instead of 2.5.0 |
Trivial |
documentation |
Chris Nauroth |
Chris Nauroth |
HDFS-5800 |
Typo: soft-limit for hard-limit in DFSClient |
Trivial |
hdfs-client |
Kousuke Saruta |
Kousuke Saruta |
MAPREDUCE-5729 |
mapred job -list throws NPE |
Critical |
mrv2 |
Karthik Kambatla |
Karthik Kambatla |
MAPREDUCE-5725 |
TestNetworkedJob relies on the Capacity Scheduler |
Major |
. |
Sandy Ryza |
Sandy Ryza |
HADOOP-10110 |
hadoop-auth has a build break due to missing dependency |
Blocker |
build |
Chuan Liu |
Chuan Liu |
MAPREDUCE-5693 |
Restore MRv1 behavior for log flush |
Major |
mrv2 |
Gera Shegalov |
Gera Shegalov |
HDFS-5434 |
Write resiliency for replica count 1 |
Minor |
namenode |
Taylor, Buddy |
|
HADOOP-10252 |
HttpServer can’t start if hostname is not specified |
Major |
. |
Jimmy Xiang |
Jimmy Xiang |
YARN-1624 |
QueuePlacementPolicy format is not easily readable via a JAXB parser |
Major |
scheduler |
Aditya Acharya |
Aditya Acharya |
YARN-1607 |
TestRM expects the capacity scheduler |
Major |
. |
Sandy Ryza |
Sandy Ryza |
HDFS-5806 |
balancer should set SoTimeout to avoid indefinite hangs |
Major |
balancer & mover |
Nathan Roberts |
Nathan Roberts |
MAPREDUCE-5723 |
MR AM container log can be truncated or empty |
Blocker |
applicationmaster |
Mohammad Kamrul Islam |
Mohammad Kamrul Islam |
HDFS-5789 |
Some of snapshot APIs missing checkOperation double check in fsn |
Major |
namenode |
Uma Maheswara Rao G |
Uma Maheswara Rao G |
HDFS-5728 |
[Diskfull] Block recovery will fail if the metafile does not have crc for all chunks of the block |
Critical |
datanode |
Vinayakumar B |
Vinayakumar B |
HDFS-5343 |
When cat command is issued on snapshot files getting unexpected result |
Major |
hdfs-client |
sathish |
sathish |
HADOOP-10203 |
Connection leak in Jets3tNativeFileSystemStore#retrieveMetadata |
Major |
fs/s3 |
Andrei Savu |
Andrei Savu |
HADOOP-9982 |
Fix dead links in hadoop site docs |
Major |
documentation |
Akira Ajisaka |
Akira Ajisaka |
HADOOP-10212 |
Incorrect compile command in Native Library document |
Major |
documentation |
Akira Ajisaka |
Akira Ajisaka |
HDFS-5297 |
Fix dead links in HDFS site documents |
Major |
documentation |
Akira Ajisaka |
Akira Ajisaka |
HADOOP-10250 |
VersionUtil returns wrong value when comparing two versions |
Major |
. |
Yongjun Zhang |
Yongjun Zhang |
HADOOP-10288 |
Explicit reference to Log4JLogger breaks non-log4j users |
Major |
util |
Todd Lipcon |
Todd Lipcon |
HDFS-5830 |
WebHdfsFileSystem.getFileBlockLocations throws IllegalArgumentException when accessing another cluster. |
Blocker |
caching, hdfs-client |
Yongjun Zhang |
Yongjun Zhang |
HADOOP-9830 |
Typo at http://hadoop.apache.org/docs/current/ |
Trivial |
documentation |
Dmitry Lysnichenko |
Kousuke Saruta |
HADOOP-10255 |
Rename HttpServer to HttpServer2 to retain older HttpServer in branch-2 for compatibility |
Blocker |
. |
Haohui Mai |
Haohui Mai |
HADOOP-10292 |
Restore HttpServer from branch-2.2 in branch-2 |
Major |
. |
Haohui Mai |
Haohui Mai |
YARN-1629 |
IndexOutOfBoundsException in Fair Scheduler MaxRunningAppsEnforcer |
Major |
scheduler |
Sandy Ryza |
Sandy Ryza |
YARN-1630 |
Introduce timeout for async polling operations in YarnClientImpl |
Major |
client |
Aditya Acharya |
Aditya Acharya |
HADOOP-10291 |
TestSecurityUtil#testSocketAddrWithIP fails |
Major |
. |
Mit Desai |
Mit Desai |
HDFS-5844 |
Fix broken link in WebHDFS.apt.vm |
Minor |
documentation |
Akira Ajisaka |
Akira Ajisaka |
YARN-1600 |
RM does not startup when security is enabled without spnego configured |
Blocker |
resourcemanager |
Jason Lowe |
Haohui Mai |
HDFS-5842 |
Cannot create hftp filesystem when using a proxy user ugi and a doAs on a secure cluster |
Major |
security |
Arpit Gupta |
Jing Zhao |
HDFS-5845 |
SecondaryNameNode dies when checkpointing with cache pools |
Blocker |
namenode |
Andrew Wang |
Andrew Wang |
HADOOP-10305 |
Add “rpc.metrics.quantile.enable” and “rpc.metrics.percentiles.intervals” to core-default.xml |
Major |
metrics |
Akira Ajisaka |
Akira Ajisaka |
HADOOP-10310 |
SaslRpcServer should be initialized even when no secret manager present |
Blocker |
security |
Aaron T. Myers |
Aaron T. Myers |
HADOOP-10317 |
Rename branch-2.3 release version from 2.4.0-SNAPSHOT to 2.3.0-SNAPSHOT |
Major |
. |
Andrew Wang |
Andrew Wang |
HADOOP-10313 |
Script and jenkins job to produce Hadoop release artifacts |
Major |
build |
Alejandro Abdelnur |
Alejandro Abdelnur |
HADOOP-10311 |
Cleanup vendor names from the code base |
Blocker |
. |
Suresh Srinivas |
Alejandro Abdelnur |
HADOOP-10273 |
Fix ‘mvn site’ |
Major |
build |
Arpit Agarwal |
Arpit Agarwal |
HDFS-5876 |
SecureDataNodeStarter does not pick up configuration in hdfs-site.xml |
Major |
datanode |
Haohui Mai |
Haohui Mai |
HDFS-5873 |
dfs.http.policy should have higher precedence over dfs.https.enable |
Major |
. |
Yesha Vora |
Haohui Mai |
MAPREDUCE-5743 |
TestRMContainerAllocator is failing |
Major |
. |
Ted Yu |
Ted Yu |
YARN-1628 |
TestContainerManagerSecurity fails on trunk |
Major |
. |
Mit Desai |
Vinod Kumar Vavilapalli |
HADOOP-10112 |
har file listing doesn’t work with wild card |
Major |
tools |
Brandon Li |
Brandon Li |
MAPREDUCE-5744 |
Job hangs because RMContainerAllocator$AssignedRequests.preemptReduce() violates the comparator contract |
Blocker |
. |
Sangjin Lee |
Gera Shegalov |
HDFS-5837 |
dfs.namenode.replication.considerLoad does not consider decommissioned nodes |
Major |
namenode |
Bryan Beaudreault |
Tao Luo |
HDFS-5921 |
Cannot browse file system via NN web UI if any directory has the sticky bit set |
Critical |
namenode |
Aaron T. Myers |
Aaron T. Myers |
YARN-1330 |
Fair Scheduler: defaultQueueSchedulingPolicy does not take effect |
Major |
scheduler |
Sandy Ryza |
Sandy Ryza |
HADOOP-9478 |
Fix race conditions during the initialization of Configuration related to deprecatedKeyMap |
Major |
conf |
Dongyong Wang |
Colin P. McCabe |